Filtering of invalid spatial values #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amogh-Bharadwaj
commented
Oct 19, 2023
Amogh-Bharadwaj
commented
- Detects invalid spatial values such as single-point linestrings and open polygons, setting them as null on the pull side for QRep and CDC
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -13,6 +14,7 @@ import ( | |||
| "github.com/jackc/pgx/v5/pgtype" | |||
| "github.com/lib/pq/oid" | |||
| log "github.com/sirupsen/logrus" | |||
| geom "github.com/twpayne/go-geos" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
could not import github.com/twpayne/go-geos (-: go build github.com/twpayne/go-geos:
| @@ -124,6 +124,12 @@ func (g *GenericSQLQueryExecutor) CountRows(schemaName string, tableName string) | |||
| return count, err | |||
| } | |||
|
|
|||
| func (g *GenericSQLQueryExecutor) CountNonNullRows(schemaName string, tableName string, columnName string) (int64, error) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 123 characters (lll)
| @@ -124,6 +124,12 @@ | |||
| return count, err | |||
| } | |||
|
|
|||
| func (g *GenericSQLQueryExecutor) CountNonNullRows(schemaName string, tableName string, columnName string) (int64, error) { | |||
| var count int64 | |||
| err := g.db.QueryRowx("SELECT COUNT(CASE WHEN " + columnName + " IS NOT NULL THEN 1 END) AS non_null_count FROM " + schemaName + "." + tableName).Scan(&count) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 162 characters (lll)
| case qvalue.QValueKindGeography, qvalue.QValueKindGeometry, qvalue.QValueKindPoint: | ||
| flattenedCastsSQLArray = append(flattenedCastsSQLArray, fmt.Sprintf("CAST(%s:\"%s\" AS STRING) AS %s,", | ||
| case qvalue.QValueKindGeography: | ||
| flattenedCastsSQLArray = append(flattenedCastsSQLArray, fmt.Sprintf("TO_GEOGRAPHY(CAST(%s:\"%s\" AS STRING),true) AS %s,", |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 134 characters (lll)
| flattenedCastsSQLArray = append(flattenedCastsSQLArray, fmt.Sprintf("TO_GEOGRAPHY(CAST(%s:\"%s\" AS STRING),true) AS %s,", | ||
| toVariantColumnName, columnName, targetColumnName)) | ||
| case qvalue.QValueKindGeometry: | ||
| flattenedCastsSQLArray = append(flattenedCastsSQLArray, fmt.Sprintf("TO_GEOMETRY(CAST(%s:\"%s\" AS STRING),true) AS %s,", |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 133 characters (lll)
iskakaushik
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.